digiKam digest - 2009-08-23

Submitted by mikolajmachowski on Wed, 2009-08-26 17:40

Looks like summer finally caught up with me ;) This week we saw cleaning of many bugs in color management area; easier navigation in HTML galleries; and drag'n'drop sorting in file widget of KIPI plugins (life saver in slideshows!). Also two new important features: much more improved and extended renaming feature and dockable thumbbar from Album GUI.

Dockable along all edges thumbbar:

This is not showfoto below!
Extended renaming. Note big buttons for speedy entry of most used values and possibility to use metadata fields:

Bug/wish table

	Opened bugs	Opened last week	Closed last week	Change	Opened wishes	Opened last week	Closed last week	Change
digikam	227	+15	-16	-1	290	+3	-3	0
kipiplugins	103	+3	-2	1	153	+3	-2	1

Full tables:

NEWS reports

Issues closed last week (note: due to different methodologies numbers may not add up with table above)

digiKam

 
+032 ==> 202532 : Wrong rename sequence when downloading.
+033 ==> 163161 : Adding ICC profiles confuses digiKam.
+034 ==> 148151 : Problem with icc profle Color Management in Digikam with feisty fawn.
+035 ==> 162944 : Cms/editor: converting colorspace doesn't work.
+036 ==> 165650 : digiKam appears to add a color profile for printing?
+037 ==> 182272 : color profile and white balance.
+038 ==> 204656 : Import: "Device Information": linebreaks not HTMLified in KTextEdits [patch].
+039 ==> 189073 : Does not save embedded color profile.
+040 ==> 195144 : Editor shows wrong colors when loading image without color profile and color management is on.
+041 ==> 152521 : Digikam Edit / Showfoto: Use Color Managed View setting in config page is ignored.
+042 ==> 163160 : Remember color management status between sessions.

Kipi-plugins


+016 ==> BatchProcessImages : 199932 : Batch resize images produces images 1 pixel too short.
+017 ==> HTMLExport         : 196968 : Add link-tags to exported HTML-galleries to ease navigation.
+018 ==> PrintWizard        : 202480 : PrintWizard doesn't add comments properly but shows them in the preview.
+019 ==> AdvancedSlideshow  :  98617 : Drag and drop custom image sort in slide show.

Selected commits

extragear/graphics/digikam (2009-08-17 18:25)


SVN commit 1012412 by aclemens:

New utility: ManualRename

This utility will replace the old ManualRenameInput widget. The goal of
this utility is to have a more flexible parser that can be expanded
quite easily.

To create a new parser, inherit from Digikam::ManualRename::Parser and
overwrite the parse() method (and, if needed, slotTokenTriggered()).

A parser can register a button or menu in the client widget, right now
the only client widget is ManualRenameWidget, that behaves like the old
ManualRenameInput widget. These buttons and menus can be used to access
a token, so that the user doesn't have to type in the actual parse
string.

Every parser has one or more token objects. The token information can be
used to create the menu actions or the button. In the
ManualRenameWidget, this information is also used to create the tooltip
helper button.
So if you add a new parser, the button, menu and tooltip is
automatically created, to minimize coding efforts.

Some parsers might want to provide additional dialogs, to show / use
them overwrite the slotTokenTriggered() method and create the dialog in
there.

The parse information has to be provided to the parse() method with a
ParseInformation object.
If you create a new parser and need additional information (right now
filename, cameraName, dateTime and index is provided), add the extra
information to the ParseInformation class and make sure the client fills
in the correct values.

The layout of the ManualRenameWidget can be controlled with flags
(TokenInputStyle):
- None: No control buttons or toolbutton with menu is shown
- BigButtons: the widget uses big buttons below the KLineInput widget.
The column number can be set in the registerParsers(int columns) method.
(used in CameraUI)
- ToolButton: a small toolbutton is shown next to the KLineInput widget.
  This is normally useful if you don't have much space in the client.
(used in BQM)

The TokenInputStyle can be combined, if needed:
setTokenInputStyle(BigButtons|ToolButton)

In the future we might even remove the "Custom" rename widgets from the
camera import dialog, because it actually is less powerful and you are
not able to change the order of the added information.
What do you think? I guess with the quick-access buttons, the
ManualRenameWidget is quite user friendly now, so the custom widget can
be removed.

CCMAIL:digikam-devel@kde.org



http://websvn.kde.org/?view=rev&revision=1012412 

35 files changed

extragear/graphics/digikam/utilities/cameragui (2009-08-18 15:20)


SVN commit 1012965 by aclemens:

At least fix the numbering sort issue, but I still think it is confusing
to see the first item name as the new name when only one item is
selected, either in iconview or the detail sidebar. It just looks like
an error, although it isn't really one.

I am aware that users might want to download only one image so I know we
can not avoid this.

I had a patch that only set a selection parameter when more than one
item was selected, but then again we can not download a single item with
the correct naming scheme. 

1 file changed

extragear/graphics/digikam/utilities/cameragui (2009-08-18 14:05)


SVN commit 1012928 by aclemens:

avoid possible crash, use QPointer as described in
http://www.kdedevelopers.org/node/3919 

1 file changed

extragear/graphics/digikam/utilities/cameragui (2009-08-18 17:34)


SVN commit 1013018 by aclemens:

no need to duplicate code here (99% is the same). We can avoid this by
simply using the following boolean expression:

if ( (hasSelection && item->isSelected()) || !hasSelection)

This should be enough and we therefore can skip the copied else {} path. 

1 file changed

extragear/graphics/digikam/utilities/manualrename/parsers (2009-08-19 13:56)


SVN commit 1013249 by aclemens:

no need to hardcode the combobox here, values can be inserted by using
DateFormat::map() 

2 files changed

extragear/graphics/kipi-plugins/htmlexport/themes (2009-08-19 14:11)


SVN commit 1013255 by gateau:

Patch by Michael Jansen to add support for up, previous, and next links.

Better late than never. Sorry for the delay :/

BUG:196968 

5 files changed

extragear/graphics/digikam/utilities/setup (2009-08-19 14:27)


SVN commit 1013267 by aclemens:

Use a groupbox to distinguish the global "album tooltip togglebutton"
from the rest of the settings.

There is still a problem with the tooltip setup:
When you disable tooltips for iconview, they are turned off for
albumfolderview, but not for iconview. Also you need to restart digiKam
to have tooltips disabled in iconview and thumbbar as well.
Anyway the albumfolder view should not be effected at all, so this is a
bug.

I will fix this later that day. 

1 file changed

extragear/graphics/digikam/digikam (2009-08-19 15:39)


SVN commit 1013296 by aclemens:

Do not affect albumfolder tooltips when iconview tooltips have been
disabled. 

3 files changed

extragear/graphics/kipi-plugins/printimages (2009-08-19 16:18)


SVN commit 1013310 by anaselli:

Fixed print to file.
Removed PirntOnePage for QImage, now one way only to print one page :)
BUG: 202480 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 10:45)


SVN commit 1013519 by aclemens:

fix memory leak 

2 files changed

extragear/graphics/kipi-plugins/common/libkipiplugins (2009-08-20 14:46)


SVN commit 1013684 by aclemens:

Allow sorting of the imageslist by Drag&Drop

BUG:98617 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 20:26)


SVN commit 1013778 by mwiesweg:

Reimplement large parts of the dialog to adapt to the three situations:
Profile Mismatch, Missing Profile, Raw Color.
Using radio buttons allows to offer more than one option at a time,
to offer more precise description of the action connected to an option,
and to select "other" profiles from a combo box.
The previews are updated when changing options. They always apply the selected option and
then display to the current monitor profile or sRGB.
I have worked hard on the layout, but improvement is possible.



http://websvn.kde.org/?view=rev&revision=1013778 

3 files changed

extragear/graphics/digikam/utilities/setup (2009-08-20 20:27)


SVN commit 1013784 by mwiesweg:

The setup page also needed redesign. It offers to select the behavior distinctly
for profile mismatch, missing profile and raw colors, and uses more room to present the options.
A goal to offer default settings so that the user just needs to enable color management
and everything "just works" (viewing and editing images with embedded color space,
display to sRGB or monitor profile)



http://websvn.kde.org/?view=rev&revision=1013784 

2 files changed

extragear/graphics/digikam/utilities/imageeditor (2009-08-20 20:27)


SVN commit 1013781 by mwiesweg:

Adapt to added color management features 

4 files changed

extragear/graphics/digikam/libs/dimg/filters (2009-08-20 20:26)


SVN commit 1013772 by mwiesweg:

Ensure that the current transform is closed when parameters change.
Various fixes. Remove readFromConfig(). 

2 files changed

extragear/graphics/digikam/libs/threadimageio (2009-08-20 20:27)


SVN commit 1013779 by mwiesweg:

Implement color management options for postprocessing in thread. 

1 file changed

extragear/graphics/digikam/libs/dimg (2009-08-20 20:26)


SVN commit 1013773 by mwiesweg:

Add methods to test for an attribute and to remove it to DImg.
In the RAW loader, properly assign the output profile to the DImg. 

5 files changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 20:26)


SVN commit 1013775 by mwiesweg:

Allow specific settings of behavior for profile mismatch, missing profile
and uncalibrated raw colors.
ICCSettingsContainer::Behavior is a mask specifying which profile is used to
interpret the image (embedded profile, sRGB, other specified profile) and which
profile it is to be converted to (workspace, or keep profile).
Special flag for Ask the User. 

2 files changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 20:26)


SVN commit 1013769 by mwiesweg:

The class IccManager is the class that knows how to construct an ICC Transformation
and how to apply it. There are methods for the various use cases of color management.
There are methods to transform an image directly, and a way to postpone color management
and ask the user in a dialog about the settings. 

2 files changed

extragear/graphics/digikam (2009-08-20 20:27)


SVN commit 1013786 by mwiesweg:

Scan profiles and load and cache all profiles properties at startup.
The idea was that this would speed up opening the ICC setup.
But to no success - profiling showed that loading profiles is not the problems
(it is mostly font metrics for the squeezed combo boxes) 

3 files changed

extragear/graphics/digikam/libs/widgets/iccprofiles (2009-08-20 20:26)


SVN commit 1013770 by mwiesweg:

A simple combo box subclass as a utility for showing Icc profiles in a combo box. 

2 files changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 17:36)


SVN commit 1014134 by mwiesweg:

Part A of the fix to avoid showing the ColorCorrectionDialog multiple times:
Rearrange the loading code in DImgInterface so that we can check if we already
have loaded the identical loading description, if load is called multiple times
from upper layers (which could result in multiple dialogs shown, if loading is very fast) 

3 files changed

extragear/graphics/digikam/libs/threadimageio (2009-08-22 16:54)


SVN commit 1014353 by mwiesweg:

Fix comparing loading descriptions to find out if another version of a RAW version is equal
or superior.
Fixes the problem the a RAW file's histogram was never loaded in main window side bar
when selected from editor. 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-22 17:09)


SVN commit 1014356 by mwiesweg:

First, call setButtonFocus in addition to setDefaultButton, else setDefaultButton is pretty useless
when no widget is explicitly selected. But we do that:
To improve keyboard navigation set focus to selected option in lower option group. 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/editor (2009-08-21 17:36)


SVN commit 1014135 by mwiesweg:

Part A of the fix to avoid showing the ColorCorrectionDialog multiple times:
Do not trigger extra slotLoadCurrent() calls by QTimer::singleShot
while the thumb bar is filled. 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-23 20:41)


SVN commit 1014765 by mwiesweg:

Add a short and simple static method to transform a QImage to sRGB 

2 files changed

extragear/graphics/digikam/libs/threadimageio (2009-08-23 20:41)


SVN commit 1014767 by mwiesweg:

small change in order of arguments and default value 

2 files changed

extragear/graphics/digikam/utilities/imageeditor (2009-08-21 18:56)


SVN commit 1014147 by mwiesweg:

Use IccManager to create color managed view transforms 

5 files changed

extragear/graphics/digikam/libs/dimg (2009-08-21 23:25)


SVN commit 1014211 by mwiesweg:

Dont output error message, just convert without conversion 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 18:56)


SVN commit 1014145 by mwiesweg:

Add a method to retrieve the monitor profile.
Optionally accepts a widget to handle multiple screens 

2 files changed

extragear/graphics/digikam/utilities/imageeditor/editor (2009-08-21 23:25)


SVN commit 1014213 by mwiesweg:

For automatic color conversion, request the workspace profile directly from the raw loader,
so that no extra conversion is required. 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-23 15:39)


SVN commit 1014662 by mwiesweg:

Fix loading of the RAW import tool again 

2 files changed

extragear/graphics/digikam (2009-08-23 19:20)


SVN commit 1014730 by cgilles:

apply patch from Pieter Edelman to make thumbbar dockable everywhere.
BUG: 203594




http://websvn.kde.org/?view=rev&revision=1014730 

18 files changed

extragear/graphics/digikam/libs/threadimageio (2009-08-23 20:42)


SVN commit 1014769 by mwiesweg:

Enabling color management for previews.
The transform is applied once in the thread, so there is no speed problem
like for color managed view in the editor.
Add support to set a displaying widget for a PreviewLoadThread.

CCBUG: 195050 

3 files changed

extragear/graphics/digikam/libs/dimg (2009-08-21 23:25)


SVN commit 1014212 by mwiesweg:

Passing a custom output profile to libkdcraw is broken somewhere.
For automatic color conversion, we want to get the RAW file to
the working color space directly. To emulate custom profile we output to
ProPhotoRGB and then convert to the desired output space (ProPhoto has
a very wide gamut) 

3 files changed

extragear/graphics/digikam/libs/threadimageio (2009-08-23 20:42)


SVN commit 1014770 by mwiesweg:

Enable color management for thumbnails.
The transformation is done on the final scaled QImage when creating a thumbnail
if an embedded ICC profile was read before. Applying to a very small image is is very fast.
We then store and display the thumbnails as sRGB.
There is so much quality loss already in a thumbnail that the little imperfection of ignoring the monitor
profile should be ok.

CCBUG: 195050 

3 files changed

extragear/graphics/digikam/libs (2009-08-23 20:41)


SVN commit 1014766 by mwiesweg:

Just use a universal scaledLoadingSize attribute instead of distinct jpegScaledLoadingSize
and pgfScaledLoadingSize 

3 files changed

extragear/graphics/digikam (2009-08-23 20:43)


SVN commit 1014771 by mwiesweg:

Set displaying widgets to retrieve monitor profile, if set, to preview views.

BUG: 195050 

5 files changed

extragear/graphics/digikam/libs/dimg/filters (2009-08-23 20:41)


SVN commit 1014764 by mwiesweg:

Add methods to transform a QImage - with simplified/restricted functionality of course 

2 files changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 18:56)


SVN commit 1014146 by mwiesweg:

Add a couple of methods for display (color managed view) transformation. 

2 files changed

extragear/graphics/digikam (2009-08-22 16:54)


SVN commit 1014352 by mwiesweg:

- try to use a correct profile for Adobe RGB (1998). If the original file is found
  (identified by md5), use it. Else use the compatible profile recently added to
  libkdcraw. Else use the broken profile - remove this as soon as we can rely
  on a recent libkdcraw being available
- remove applergb.icm with wrong whitepoint from default profiles 

3 files changed

KDE/kdegraphics/libs/libkdcraw/profiles (2009-08-22 15:56)


SVN commit 1014342 by mwiesweg:

Provide an AdobeRGB (1998) compatible profile.
The existing adobergb.icm here has a wrong whitepoint D50.
(Note: applergb.icm as well)
Comes with Oyranos under zlib license.
Adobe does not allow to name this "AdobeRGB (1998)" because it is not created
by Adobe. But it is created according to the specification. 

1 file changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 13:51)


SVN commit 1014076 by marten:

If the "[Color Management] DefaultPath" is not set in the digikam settings,
IccSettings::loadAllProfilesProperties() will do a recursive scan of the
current directory (most likely, the user's home directory) on digkam startup.
This will take a long time even in the best case, but if a symbolic link to a
directory is encountered it will be followed even if is a circular reference -
so going into an infinite loop.

Check extraPath in IccSettings::allProfiles(), and don't use it if it is blank.
Also do not recursively scan a directory which is a symlink. 

1 file changed

extragear/graphics/digikam (2009-08-21 17:36)


SVN commit 1014132 by mwiesweg:

Ensure to call cmsErrorAction at startup 

3 files changed

extragear/graphics/digikam/utilities (2009-08-21 23:25)


SVN commit 1014210 by mwiesweg:

Fine-tune default settings 

3 files changed

extragear/graphics/digikam/libs/dimg (2009-08-23 20:38)


SVN commit 1014760 by mwiesweg:

Add a method to load image data, but skip metadata or ICC profile (for thumbnails e.g.) 

2 files changed

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-23 20:40)


SVN commit 1014762 by mwiesweg:

Add a method to just access if color management is enabled or not (sometimes there is no need to get full settings) 

2 files changed

mikolajmachowski's blog

Navigation

Navigation

Search

Donation & Sponsor

Who's online

Syndicate

digiKam digest - 2009-08-23

Bug/wish table

NEWS reports

digiKam

Kipi-plugins

Selected commits

extragear/graphics/digikam (2009-08-17 18:25)

extragear/graphics/digikam/utilities/cameragui (2009-08-18 15:20)

extragear/graphics/digikam/utilities/cameragui (2009-08-18 14:05)

extragear/graphics/digikam/utilities/cameragui (2009-08-18 17:34)

extragear/graphics/digikam/utilities/manualrename/parsers (2009-08-19 13:56)

extragear/graphics/kipi-plugins/htmlexport/themes (2009-08-19 14:11)

extragear/graphics/digikam/utilities/setup (2009-08-19 14:27)

extragear/graphics/digikam/digikam (2009-08-19 15:39)

extragear/graphics/kipi-plugins/printimages (2009-08-19 16:18)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 10:45)

extragear/graphics/kipi-plugins/common/libkipiplugins (2009-08-20 14:46)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 20:26)

extragear/graphics/digikam/utilities/setup (2009-08-20 20:27)

extragear/graphics/digikam/utilities/imageeditor (2009-08-20 20:27)

extragear/graphics/digikam/libs/dimg/filters (2009-08-20 20:26)

extragear/graphics/digikam/libs/threadimageio (2009-08-20 20:27)

extragear/graphics/digikam/libs/dimg (2009-08-20 20:26)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 20:26)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-20 20:26)

extragear/graphics/digikam (2009-08-20 20:27)

extragear/graphics/digikam/libs/widgets/iccprofiles (2009-08-20 20:26)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 17:36)

extragear/graphics/digikam/libs/threadimageio (2009-08-22 16:54)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-22 17:09)

extragear/graphics/digikam/utilities/imageeditor/editor (2009-08-21 17:36)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-23 20:41)

extragear/graphics/digikam/libs/threadimageio (2009-08-23 20:41)

extragear/graphics/digikam/utilities/imageeditor (2009-08-21 18:56)

extragear/graphics/digikam/libs/dimg (2009-08-21 23:25)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 18:56)

extragear/graphics/digikam/utilities/imageeditor/editor (2009-08-21 23:25)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-23 15:39)

extragear/graphics/digikam (2009-08-23 19:20)

extragear/graphics/digikam/libs/threadimageio (2009-08-23 20:42)

extragear/graphics/digikam/libs/dimg (2009-08-21 23:25)

extragear/graphics/digikam/libs/threadimageio (2009-08-23 20:42)

extragear/graphics/digikam/libs (2009-08-23 20:41)

extragear/graphics/digikam (2009-08-23 20:43)

extragear/graphics/digikam/libs/dimg/filters (2009-08-23 20:41)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 18:56)

extragear/graphics/digikam (2009-08-22 16:54)

KDE/kdegraphics/libs/libkdcraw/profiles (2009-08-22 15:56)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-21 13:51)

extragear/graphics/digikam (2009-08-21 17:36)

extragear/graphics/digikam/utilities (2009-08-21 23:25)

extragear/graphics/digikam/libs/dimg (2009-08-23 20:38)

extragear/graphics/digikam/utilities/imageeditor/canvas (2009-08-23 20:40)

Recent blog posts

Featured Sponsor